Skip to content

Delete the external-engine path from SGLangEngine - #1981

Merged
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-26
Sep 4, 2026
Merged

Delete the external-engine path from SGLangEngine#1981
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-26

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 30, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 9f42682 to faf1d92 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 3123a8f to cbadb7c Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from a21e6bb to e7ef372 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from cbadb7c to 8927d52 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from e7ef372 to 49d21a0 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 8927d52 to 7d2f201 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 49d21a0 to b11c809 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 7d2f201 to 5a0bca3 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from b11c809 to 43fca99 Compare August 6, 2026 03:47
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 3beb445 to d86a0fc Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from ae51901 to d2d561e Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from d86a0fc to 1a9320a Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from d2d561e to 5691205 Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 1a9320a to 206c9ba Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 5691205 to bfb3d73 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 3 times, most recently from b4c1d1f to b730093 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 8490768 to d85d452 Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 3cf0e02 to 9dcccc7 Compare August 14, 2026 04:46
guapisolo
guapisolo approved these changes Aug 26, 2026
View reviewed changes

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in stack context: PR #1981’s orphan external-check computation and stale tuple-unpacking test helper are both fixed by PR #2096, before #2176, and the corrected files remain unchanged through checked tip #2649.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from d85d452 to c2c713c Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 9dcccc7 to 6fed792 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from c2c713c to 5d407f0 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 6fed792 to 2d0b778 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 5d407f0 to ad3d6b4 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 2d0b778 to 9371ff4 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from ad3d6b4 to fdf845c Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 9371ff4 to e0a2253 Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from fdf845c to fc9d7f3 Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from e0a2253 to 4f550cf Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from fc9d7f3 to db91727 Compare September 3, 2026 06:20
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from bb9f37d to 4350322 Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from db91727 to 33836ed Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 473f919 to f089c74 Compare September 3, 2026 10:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 240cc9e to ec33357 Compare September 3, 2026 10:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from f089c74 to d3957c1 Compare September 3, 2026 23:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 1de8cff to a4f1190 Compare September 4, 2026 00:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from d3957c1 to 49026f3 Compare September 4, 2026 00:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from a4f1190 to 7f9e3c3 Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 49026f3 to 3a913f3 Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 7f9e3c3 to 9c23a03 Compare September 4, 2026 05:36
Base automatically changed from tom/refactor-miles/op13-25 to main September 4, 2026 05:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 3a913f3 to 655f030 Compare September 4, 2026 05:36
@fzyzcjy
fzyzcjy merged commit eb1c5a5 into main Sep 4, 2026
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guapisolo guapisolo guapisolo approved these changes
@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu yushengsu-thu is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo